fix: prevent argparse from eating up abbreviated args that should be passed to the runner #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passed to the runner
|
Please note - due to some strange conflict, I wasn't able to run ruff. If the formatting is off, I'd appreciate a push to the branch with the correct formatting (or you can take the PR and fix the formatting). |
|
Hi @radoshi, Thank you for your contribution! The PR looks good to me, but it needs to be formatted to merge. Could you try to run ruff like the following: ruff check --fix . |
|
Thanks. Gave this a shot. For some reason, ruff check --fix . doesn't fix
the problem (though it does tell me what is wrong.) I fixed it manually and
`ruff check .` passes now.
I usually run this from vscode, and that failed because vscode expects a
newer version of ruff (current one is at 0.0.275). Probably a separate PR
to update ruff versions in the lockfile.
Please give the latest a shot and see if it passes.
…On Sun, Mar 24, 2024 at 11:53 AM Olzhas Arystanov ***@***.***> wrote:
Hi @radoshi <https://github.com/radoshi>,
Thank you for your contribution!
The PR looks good to me, but it needs to be formatted to merge.
What error are you getting when trying to format the code?
Could you try to run ruff like the following:
ruff check --fix .
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQQVGFPALUW2GTY5ZRUADYZ4OJ5AVCNFSM6AAAAABFAXY5OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEYDINRXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
okay, sent you #31 to cover the ruff version updates. |
olzhasar
approved these changes
Mar 25, 2024
olzhasar
added a commit
that referenced
this pull request
Apr 2, 2024
* build: update deps, remove isort and black. * fix: prevent argparse from eating up abbreviated args that should be passed to the runner (#29) * fix: prevent argparse from eating up abbreviated args that should be passed to the runner * build: fixing with `ruff check .` * build: formatting update. * Add python 3.12 to the tox.ini * Bump version 0.4.1 -> 0.4.2 * Update CHANGELOG * Add python 3.12 to github test workflow * Update LICENSE * build: update deps, remove isort and black. * Update pre-commit hooks. Instruct ruff to sort --------- Co-authored-by: olzhasar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparseoptimistically shortens arguments when things are unambigous.This means that
--ignore /some/patternwill get matched to--ignore-patterns /some/pattern. This is not the intended behavior when trying to pass--ignoreto pytest.This PR:
test_parse_argumentsunit test, which wasn't really testing anything.All tests pass.