-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time reference and decimal places #481
Merged
Merged
Changes from 17 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b6c99ab
DeltaT offset from T idx (1-based)
Tom-TBT e6bd374
JS DeltaT offset from T idx(1-based)
Tom-TBT 42449a2
Renamed dT offset parameter
Tom-TBT d2726ca
Merge branch 'ome:master' into dT_offset
Tom-TBT 0148cd4
Default to 0 when shift with no timestamps
Tom-TBT 7a10b1d
Added precision param to time and XYZWH labels
Tom-TBT 33a4156
Refactoring code
Tom-TBT 146d300
Bug fix in text between dynamic label
Tom-TBT 18e6259
Dec prec bug fix
Tom-TBT c174fcb
updated tip window
Tom-TBT 76f2897
updated format spec
Tom-TBT a5a27ec
limit behavior js/pdf fix
Tom-TBT 0b9719d
Added label tests
Tom-TBT f5c848f
dec_prec fix when 0 with a view property
Tom-TBT 6473162
removed alias from label tips
Tom-TBT 40b3ffa
Removed bug fix for a separate PR
Tom-TBT 14a6167
added mixed example to tips
Tom-TBT 0c44a12
Updated image JSON in test
Tom-TBT 3f05340
z.unit label bug fix for 2d images
Tom-TBT 0870664
Merge branch 'ome:master' into dT_offset
Tom-TBT 29d0fe1
0 default on X.unit when px size not set
Tom-TBT 62ceba4
Merge branch 'dT_offset' of https://github.com/Tom-TBT/omero-figure i…
Tom-TBT 55891b7
test json None px_size handling
Tom-TBT cbee1da
improved label tip description
Tom-TBT c3318df
Prettifying conditional operators
Tom-TBT 59a4ca7
Label-parameter format change to readable
Tom-TBT d8c2580
style fix
Tom-TBT 377c620
X/Y with precision 0 bug fix
Tom-TBT 98e4439
Changed tip window on label parameter
Tom-TBT 711920b
Bug fix of default view label precision
Tom-TBT 0c5cf6d
Updated doc
Tom-TBT b06c9d2
More pythony key in dict handling
Tom-TBT 765df8c
Initializing variables explicitly
Tom-TBT fd5c427
Bug fix, dataset ID
Tom-TBT eac902e
Style and stability adjustments
Tom-TBT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a heads up, my inclination is that this format won't be readily understandable by users. Sorry if I missed it, but was there any discussion of the cost/benefit trade-off on having a larger but more self-documenting format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brainstorming:
time[3].{unit:.2f}
(more python-y)[time.unit;offset=3;precision=2]
(more readable)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[time.unit;offset=3;precision=2]
I like that one. It's readable, won't be much effort to implement and we don't need to worry about the order of parameter