Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCS schemas to the GH pages publication script #3

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jul 5, 2022

@sbesson sbesson requested a review from will-moore July 5, 2022 07:51
@will-moore
Copy link
Member

Changes look good. I'm assuming that the schemas aren't actually deployed to https://ngff.openmicroscopy.org/0.4/schemas/plate.schema and https://ngff.openmicroscopy.org/0.4/schemas/well.schema until after this is merged?

@sbesson
Copy link
Member Author

sbesson commented Jul 5, 2022

That's correct. Ideally this could be replaced by wilcard to copy everything under /schemas for each version but my attempts have failed so that's the easiest way to publish things

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM 👍

@sbesson sbesson merged commit 71ed9be into ome:main Jul 5, 2022
@sbesson
Copy link
Member Author

sbesson commented Jul 5, 2022

Re-executed https://github.com/ome/ngff/actions/runs/2611161053 which in turn updated the GitHub Pages. The schemas should now be available live

@sbesson sbesson deleted the hcs_schemas branch July 5, 2022 10:28
@joshmoore
Copy link
Member

👍 We probably need to document all the steps for adding a schema somewhere.

@sbesson
Copy link
Member Author

sbesson commented Jul 6, 2022

Agreed. Thoughts about https://github.com/ome/ngff#release-process or a separate section?

@joshmoore
Copy link
Member

Starting there probably makes sense. Eventually, I'd imagine a how to as part of the spec itself concerning the process, etc. But that needs a good deal of drafting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants