Creating patch release #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arrobo, Gabriel <[email protected]>
thakurajayL
reviewed
Feb 21, 2025
| @@ -150,7 +150,7 @@ config: | |||
| profileName: profile2 | |||
| enable: true | |||
| gnbName: gnb1 | |||
| execInParallel: false #run all subscribers in this profile parallel | |||
| execInParallel: true #run all subscribers in this profile parallel | |||
There was a problem hiding this comment.
Why these changes? Any specific reason?
There was a problem hiding this comment.
This is useful to spend less time when running the default profile (profile2)
There was a problem hiding this comment.
FYI, these values are relevant only if they are not overwritten. Otherwise, they are ignored
| @@ -234,7 +234,7 @@ config: | |||
| defaultAs: "192.168.250.1" #default icmp pkt destination | |||
| - profileType: pdusessest | |||
| profileName: profile8 | |||
| enable: true | |||
| enable: false | |||
There was a problem hiding this comment.
Why these changes? Any specific reason?
There was a problem hiding this comment.
This change is to make sure that only profile2 is enabled by default
There was a problem hiding this comment.
FYI, these values are relevant only if they are not overwritten. Otherwise, they are ignored
thakurajayL
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
cert-managerThese changes have been tested with OnRamp