Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minimal changes in order to be as easy as possible to merge. However, the main reason I've created this PR is PR #26 will only work with vanilla logs. In that sense, this is a more correct implementation (as much as is possible since Material was removed). Instead of hard-coding some vanilla log types, this PR uses the
minecraft:logs
block tag, which must work for any mod using vanilla's LeavesBlock without significant modification, because that is the tag used in vanilla decay.It is possible some mods with a custom leaves implementation may not work (may not add their logs to
minecraft:logs
), but I did not find any such mods in a brief survey of major Fabric biome mods. I don't think we need to worry about this, but if you want an implementation that should work in roughly any case the Material-based implementation did, the following is fairly equivalent. (I've noticed some mods seem to take a lot of liberties in their mapping of block sound group to wood type, so this doesn't assume bamboo isn't used for real logs or nether can't be a tree with leaves.)