Snippet type fix, lint fix, code refactor and cleanup #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @omeralpi. I think we're finished here. Could we merge? |
Hi. I’m still reviewing the PR. Once everything is finalized, we’ll proceed with the merge. Thank you for your interest. |
|
We should make a React 19 version alongside this afterwards |
omeralpi
added a commit
that referenced
this pull request
Nov 16, 2024
* remove unnecessary filter * remove unnecessary displayName assignment * remove another unnecessary check * value is always truthy * use tailwind size instead of h and w + format * some refactor and cleanup * fix: update PhoneInputProps to omit "ref" in type definition --------- Co-Authored-By: omeralpi <[email protected]>
omeralpi
added a commit
that referenced
this pull request
Nov 16, 2024
* remove unnecessary filter * remove unnecessary displayName assignment * remove another unnecessary check * use tailwind size instead of h and w + format * some refactor and cleanup * fix: update PhoneInputProps to omit "ref" in type definition --------- Co-Authored-By: omeralpi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.