Quasar Fast Exit: Add IFE Claims for Byzantine conditions #724
Conversation
| describe('And Quasar maintainer deploys and adds liquid funds to the Quasar', () => { | ||
| before(async () => { | ||
| await setupQuasar(); | ||
| this.quasarCapacityBeforeAddingFunds = new BN(await this.quasar.tokenUsableCapacity(ETH)); |
There was a problem hiding this comment.
I presume this simply means inital quasar funds. which... is empty aka. 0?
There was a problem hiding this comment.
Yes, right. It is empty at this moment
| }); | ||
|
|
||
| describe('And then Alice tries to obtain a ticket from the Quasar using the output', () => { | ||
| describe('If the output is from block over the safe-blocknum', () => { |
There was a problem hiding this comment.
what is the logic behind a to old output coming from block num?
There was a problem hiding this comment.
aha, so... I think I understand.
It's also a question I wanted to ask you earler.
The reason you need this, is because the contracts don't know if the chain is byzantine or not, correct? Only Watchers have the functionality of declaring (raising) byzantine events.
So with this parameter you declare what the operator of the quasar thinks is blknum up to which the chain is byzantine safe. Correct?
There was a problem hiding this comment.
Another one - the functionality of updateSafeBlockLimit implies that the operator of the quasar needs to perpetually update this safe block number, correct?
If this is true (open for debate):
-
perhaps we need a way to declare it always safe? From the conversation with Leslie I understood we want to be aggresive with parameters, since we're running Watchers, Childchain and the challenge infrastructure.
-
if it's not safe or too risky, perhaps we need to include this in the Watcher or some other component, that would ask Watcher - Up to where are you byzantine free - and update the Quasar contract accordingly?
There was a problem hiding this comment.
Exactly!
yes, the updateSafeBlockLimit is a bit cumbersome. One safe way we thought about was-
In the current design, there is a requirement for the Quasar owner to constantly keep updating the Safe Blocknum upper-bound.
An alternative could be - Provide tickets for a UTXO if either one of these satisfy:
- UTXOs is older than (Latest_Block_timestamp - Buffer), ideally the buffer could take the value of the minimum validation period. or
- UTXO is from a safe block (determined by safe blocknum upper-bound) set by the Owner
Yes, i feel the same about your points too. since we are the only one running this for now
about 2) Yes this is a good idea, since we run our own watcher, we could run a service that could ping our watcher periodically to update the safe block limit
| this.framework.address, | ||
| this.spendingConditionRegistry.address, | ||
| quasarOwner, | ||
| 0, |
There was a problem hiding this comment.
I know it's stupid but it would be great if we could pass in a named variable to a constructor that takes 6 arguments, it's just easier to know what it is. In this case
safePlasmaBlockNum = 0;
There was a problem hiding this comment.
sure, will do that
| this.waitingPeriod = 14400; | ||
| this.ifeWaitingPeriod = 691200; | ||
| this.dummyQuasarBondValue = 500; | ||
|
|
There was a problem hiding this comment.
| safePlasmaBlockNum = 0; |
Includes -