-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruby-saml
to 1.1
#66
Conversation
I think this should actually be like this: gem.add_runtime_dependency 'ruby-saml', '~> 1.1', '>= 1.1.1' Version 1.1.0 was broken. |
@md5 good point. I updated the commit. |
and fixed it again, because I read your comment too fast 😛 |
👍 |
@md5 thanks for the feedback, it would be awesome to get this merged. |
@bpedro any chance we can get this merged soon? |
@brendankemp any chance we can get this reviewed? |
@danwiding is in charge of this project now. He can get you sorted :) |
Source: supernova32/master omniauth#66
@danwiding Would you be able to merge this and prepare a new release in the near future? Thanks a lot! |
I guess our only option going forward is to fork this gem, since we have not heard back from the maintainers and the project seems to be abandoned. |
@bufferoverflow @supernova32 @md5 @dosire Hey so I guess I've inherited this. I'll be honest my org has moved away from active maintenance of this gem well before I even joined. I believe @bpedro is the intended maintainer. At any rate, I just granted each of you write privileges to this repo so as to deal with issues like this in the future. However, as a longer term solution I'd like to figure out what org or user account this gem should belong to. If you'd like to take active ownership speak up. |
If no one organization wants to take over maintainership, it might make sense to follow the model adopted for Ryan Bates' CanCan gem. In that case, the community basically created its own organization to hold their fork. They also renamed the gem, presumably since they did not have access to the original on rubygems.org, but perhaps that step would not be necessary in this case. EDIT: see #67 |
@danwiding I would love to take over the maintainership of this gem. I commented on the new issue that @ilikepi created. |
Ruby SAML 1.1 was released a couple of months ago and includes some important changes, most importantly the support for SAMLResponse without ds:x509certificate.
This is needed for some environments where GitLab EE is running.
Also bumped the version to 1.4.1 to release a new gem.