Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: coderabbitai 테스트 #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

merge: coderabbitai 테스트 #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/main/kotlin/com/onboard/server/domain/HelloController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package com.onboard.server.domain

import org.springframework.stereotype.Controller
import org.springframework.web.bind.annotation.GetMapping
import org.springframework.web.bind.annotation.RequestMapping
import org.springframework.web.bind.annotation.RestController

@RequestMapping("/say")
@Controller
@RestController
Comment on lines +8 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant @Controller annotation.

The @RestController annotation already includes @Controller, making it redundant.

- @Controller
- @RestController
+ @RestController

Committable suggestion was skipped due to low confidence.

class HelloController {
companion object {
const val ABCDE = "abcde"
}

constructor()

Comment on lines +16 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary constructor.

Kotlin provides a default constructor, so this explicit declaration is unnecessary.

- constructor()
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
constructor()

@GetMapping("/hello")
fun hello() = "hello"

@GetMapping("/move")
fun move() = "move"

Check failure on line 23 in src/main/kotlin/com/onboard/server/domain/HelloController.kt

View workflow job for this annotation

GitHub Actions / lint 

[ktlint] reported by reviewdog 🐶
Unexpected blank line(s) before "}"

Raw Output:
src/main/kotlin/com/onboard/server/domain/HelloController.kt:23:1: error: Unexpected blank line(s) before "}" (standard:no-blank-line-before-rbrace)

Check failure on line 24 in src/main/kotlin/com/onboard/server/domain/HelloController.kt

View workflow job for this annotation

GitHub Actions / lint 

[ktlint] reported by reviewdog 🐶
Needless blank line(s)

Raw Output:
src/main/kotlin/com/onboard/server/domain/HelloController.kt:24:1: error: Needless blank line(s) (standard:no-consecutive-blank-lines)


}
Comment on lines +23 to +27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary blank lines.

There are unexpected blank lines before the closing brace.

- 
- 
- 
-
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
}
}
Tools
GitHub Check: lint

[failure] 23-23:
[ktlint] reported by reviewdog 🐶
Unexpected blank line(s) before "}"

Raw Output:
src/main/kotlin/com/onboard/server/domain/HelloController.kt:23:1: error: Unexpected blank line(s) before "}" (standard:no-blank-line-before-rbrace)

[failure] 24-24:
[ktlint] reported by reviewdog 🐶
Needless blank line(s)

Raw Output:
src/main/kotlin/com/onboard/server/domain/HelloController.kt:24:1: error: Needless blank line(s) (standard:no-consecutive-blank-lines)


Loading