Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function to ignore hidden questions #325

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Conversation

sharon2719
Copy link
Contributor

@sharon2719 sharon2719 commented Jan 14, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue
Closes #319

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built using the command ./gradlew clean assemble and run the efsity jar to verify my change fixes the issue and does not break the application

@sharon2719 sharon2719 marked this pull request as ready for review January 15, 2025 09:13
@sharon2719 sharon2719 requested a review from Wambere January 15, 2025 09:14
Copy link
Contributor

@Wambere Wambere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharon2719 the main reason we are ignoring these questions is because they are "ideally" pre-populated by something else. Is it possible to trigger whatever should do this pre-population so that these answers are also in the response?

@sharon2719
Copy link
Contributor Author

@sharon2719 the main reason we are ignoring these questions is because they are "ideally" pre-populated by something else. Is it possible to trigger whatever should do this pre-population so that these answers are also in the response?

Most of the prepopulation is done by the rules that re set in the profiles and registers. Probably we can come up with a way that will do. Some are also linked to other questionnaires ie commodity

@Wambere
Copy link
Contributor

Wambere commented Jan 15, 2025

Most of the prepopulation is done by the rules that re set in the profiles and registers. Probably we can come up with a way that will do. Some are also linked to other questionnaires ie commodity

Can we maybe scope a separate issue for this? Something like if you choose to ignore these hidden questions the response will come up empty, but if you'd like them populated then you have the option of passing in the profile or register etc?

@sharon2719
Copy link
Contributor Author

Most of the prepopulation is done by the rules that re set in the profiles and registers. Probably we can come up with a way that will do. Some are also linked to other questionnaires ie commodity

Can we maybe scope a separate issue for this? Something like if you choose to ignore these hidden questions the response will come up empty, but if you'd like them populated then you have the option of passing in the profile or register etc?

Sure this is very okay

@pld pld merged commit 537e285 into main Jan 15, 2025
4 checks passed
@pld pld deleted the ignore-hidden-questions branch January 15, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore hidden questions when generating QuestionnaireResponses
3 participants