Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request parameters for dropdown for appId field in user creation form. #1532

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

peterMuriuki
Copy link
Collaborator

@peterMuriuki peterMuriuki commented Jan 30, 2025

For appId field in the user management form:

  • replace paginatedAsyncSelect with a local searchable select widget since the filtering is bit involved and not exactly supported by the api.
    • We display the title, and identifier fields in the dropdown.
    • The identifier field is not predictivily-searchable on the API using the :contains qualifier. The new select widget does the filtering client side.
  • Updated the filters used to query for composition resources that act as the dropdown options in the select widget above.

other changes:

  • update paginatedAsyncSelect to render correct empty response when the component is loading. It was previously erroneously showing the number 0

  • tests are included and passing

@peterMuriuki peterMuriuki merged commit 6045939 into main Feb 11, 2025
2 checks passed
@peterMuriuki peterMuriuki deleted the 1503-app-id branch February 11, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update fetching Composition Resources to use both type and category
1 participant