Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for getting total votes per electrol race #436

Merged

Conversation

JohnMwashuma
Copy link
Member

@JohnMwashuma JohnMwashuma commented Nov 7, 2024

Task checklist


  • Fix logic for getting total votes per electrol race
    • Only use result model for results and filter by form state = archived
  • Fix searching ballots list
  • Add test for ballot list data view

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (14af9ff) to head (9661b44).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   80.81%   80.94%   +0.13%     
==========================================
  Files         145      145              
  Lines        9439     9436       -3     
==========================================
+ Hits         7628     7638      +10     
+ Misses       1811     1798      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnMwashuma JohnMwashuma merged commit 753cc1e into master Nov 7, 2024
8 checks passed
@JohnMwashuma JohnMwashuma deleted the fix-total-valid-votes-on-candidates-results-report branch November 7, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants