Fix dividedmaze #169
Merged
Fix dividedmaze #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the before and after example. |
|
Great, thanks! |
|
Sorry, I haver accidentally added the two images as well. Feel free to delete them. Also, see my related comment in #76 about my further plans on DividedMaze. I'm happy to contribute if you think they are matching with your intentions. |
Why not! If you manage to maintain API compatibility and set those options to defaults that provide the current implementation... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DividedMaze generator algorithm allowed holes on the walls on odd coordinates, and that prevented additional wall building on both sides of that hole, resulting in mazes with some 3-wide corridors.
As a simple fix, I have added an extra check for each of the four walls to only store their even coordinates in the list of potential hole coordinates.