cpu: aarch64: non-global stats mode for ACL lnorm #2215
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michalowski-arm
commented
Nov 14, 2024
michalowski-arm
commented
- Change acl_layer_normalization to support non-global stats only
- Remove mean and variance check for ACL lnorm from benchdnn
* Change acl_layer_normalization to support non-global stats only --
ACL does not support global stats
* Remove mean and variance check for ACL lnorm from benchdnn --
ACL does not support returning them
michalowski-arm
force-pushed
the
acl-lnorm
branch
from
8618581
to
94d54da
Compare
dzarukin
reviewed
Nov 14, 2024
| "ACL only supports forward training with lnorm if stats " | ||
| "are provided (use global stats)"); | ||
| ACL_CHECK_SUPPORT(use_global_stats(), | ||
| "ACL does not support global stats with lnorm"); |
There was a problem hiding this comment.
Does it mean that that ACL would compute mean and variance internally but wouldn't return them to the user?
There was a problem hiding this comment.
That's correct
There was a problem hiding this comment.
Any chance ACL will update their functionality to start returning mean and var to be aligned with oneDNN?
There was a problem hiding this comment.
As an additional note, it seems that supporting only prop_kind::inference (and dropping prop_kind::training from supported) is a cleaner way to indicate that mean and variance are not going to be returned to the user.
@mgouicem, would you agree with this statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.