[NFC] add a few missing template keywords #1447
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few missing
template
keywords to fix compilation errors and warnings with a very recent clang 19 (probably due to this LLVM commit in this PR).This PR only addresses the three specific ones that failed my compilation; more generally an expression of the form
this->base<T>::func()
for some base class template
base
with a member functionfunc
(CRTP) should probably beExample compilation error and warning:
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information