Export PersistentSlabStorage funcs in export_test.go #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxamacker
force-pushed
the
fxamacker/export-persistentslabstorage-funcs-for-testing
branch
from
c994827 to
749cf71
Compare
turbolent
approved these changes
Jan 27, 2025
fxamacker
changed the base branch from
fxamacker/use-NewDefaultDigesterBuild-func-in-tests
to
main
Currently, some tests are using unexported fields of PersistentSlabStorage. This commit improves decoupling: - in storage.go, create unexported functions for those fields - in export_test.go, export those unexported functions in same package, so those exported functions can be used for testing in test package. - modify tests to use the newly exported functions.
fxamacker
force-pushed
the
fxamacker/export-persistentslabstorage-funcs-for-testing
branch
from
749cf71 to
1022e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #464
Currently, some tests are using unexported fields of
PersistentSlabStorage.This commit improves decoupling:
mainbranchFiles changedin the Github PR explorer