Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor smoke test to reduce duplicate code #506

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Refactor smoke test to reduce duplicate code #506

merged 1 commit into from
Feb 12, 2025
+674 −1,715

Conversation

fxamacker
Copy link
Member

Updates #464

This PR reuses functions recently moved to the test_utils package.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Refactor smoke test to reduce duplicate code
02764b9 
This commit reuses functions recently moved to the test_utils pkg.
@fxamacker fxamacker self-assigned this Feb 12, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 12, 2025 20:29
@fxamacker fxamacker changed the base branch from fxamacker/rename-stress-tests to main February 12, 2025 23:38
@fxamacker fxamacker merged commit 71d90d8 into main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent