Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split storable.go & typeinfo.go into smaller files #510

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

fxamacker
Copy link
Member

Updates #464

This change makes the code easier to read and maintain.

This PR splits typeinfo.go into:

  • compactmap_extradata.go
  • extradata.go
  • typeinfo.go

This PR also moves:

  • SlabIDStorable to slab_id_storable.go
  • CBOR tag numbers allocated for atree to cbor_tag_nums.go
  • etc.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

This change makes the code easier to read and maintain.

This commit splits typeinfo.go into:
- compactmap_extradata.go
- extradata.go
- typeinfo.go

This commit also moves:
- SlabIDStorable to slab_id_storable.go
- CBOR tag numbers allocated for atree to cbor_tag_nums.go
- etc
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fxamacker fxamacker changed the base branch from fxamacker/reorganize-map-code to main February 14, 2025 20:28
@fxamacker fxamacker merged commit f41c041 into main Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants