[Benchnet] Allow configuring view times faster than 1s #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6446 +/- ##
=======================================
Coverage 41.22% 41.23%
=======================================
Files 2054 2054
Lines 182347 182359 +12
=======================================
+ Hits 75175 75189 +14
+ Misses 100871 100870 -1
+ Partials 6301 6300 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Sep 6, 2024
AlexHentschel
approved these changes
Sep 6, 2024
| @@ -85,6 +86,7 @@ func init() { | |||
| flag.IntVar(&testExecutionCount, "test-execution", DefaultTestExecutionCount, "number of test execution") | |||
| flag.UintVar(&nClusters, "nclusters", DefaultNClusters, "number of collector clusters") | |||
| flag.Uint64Var(&numViewsEpoch, "epoch-length", 10000, "number of views in epoch") | |||
| flag.Uint64Var(&numViewsPerSecond, "epoch-view-rate", 1, "number of views per second") | |||
There was a problem hiding this comment.
I would suggest to call this target-view-rate because its describes a property of the network across all epochs (in comparison, the other parameters epoch-* usually specify something for one epoch, like the views within one epoch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure view times faster than the default of 1 per second by adding
--epoch-view-rate Nto the bootstrap tool