Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Verification of non-system-chunk service events #6629

Draft
wants to merge 5 commits into
base: feature/efm-recovery
Choose a base branch
from

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 7, 2024

Implements a basic version of Proposal 1 from #6622. Most likely we will go ahead with Proposal 2 and discard this PR.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.

Project coverage is 41.72%. Comparing base (5ae48c4) to head (e265500).

Files with missing lines Patch % Lines
model/flow/execution_result.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/efm-recovery    #6629    +/-   ##
======================================================
  Coverage                 41.72%   41.72%            
======================================================
  Files                      2019     2028     +9     
  Lines                    179401   180229   +828     
======================================================
+ Hits                      74849    75197   +348     
- Misses                    98395    98839   +444     
- Partials                   6157     6193    +36     
Flag Coverage Δ
unittests 41.72% <64.86%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants