Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building private dependencies in CI #6728

Open
wants to merge 1 commit into
base: v0.37
Choose a base branch
from

Conversation

sjonpaulbrown
Copy link
Collaborator

@sjonpaulbrown sjonpaulbrown commented Nov 15, 2024

PR Description: Add Support for Building Private Dependencies in CI

This PR introduces changes to support building private dependencies in the CI pipeline, specifically for private Cadence repositories.


Key Changes

  1. Update CI steps to load Cadence Deploy Key in CI:

    • Adds CI step to load the CADENCE_DEPLOY_KEY into the SSH agent for accessing private repositories.
    • Configures Git to use SSH for dependencies.
    • Dynamically sets SSH_AUTH_SOCK in the environment.
    • Warns if CADENCE_DEPLOY_KEY is not set, allowing the workflow to continue.
  2. Update GOPRIVATE Configuration:

    • Updates GOPRIVATE to github.com/onflow/* in both the GitHub Actions workflow and the Makefile to bypass the Go module proxy for private repositories.

Impact

These changes enable seamless fetching and building of private Cadence dependencies during CI, improving the reliability and security of the build process.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.54%. Comparing base (4162017) to head (337d345).

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6728      +/-   ##
==========================================
- Coverage   41.55%   41.54%   -0.02%     
==========================================
  Files        2026     2026              
  Lines      181069   181069              
==========================================
- Hits        75248    75228      -20     
- Misses      99595    99615      +20     
  Partials     6226     6226              
Flag Coverage Δ
unittests 41.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjonpaulbrown sjonpaulbrown marked this pull request as ready for review November 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants