fix(extensions): Race condition in search subscription (#2478)

__Issue:__ The extension-search subscription (as well as potentially others) - had a race condition: if a long running subscription `s0` was kicked off, and then disposed/replaced with a newer, shorter-running subscription `s1`, if the search triggered by `s0` occurred after `s1`, it would replace `s1`'s results. __Defect:__ The 'mental model' for the subscription like `Isolinear.Sub.t(msg)` is that, when active, they can potentially dispatch `msg`'s arbitrarily. However, when they are disposed and not active, they should not trigger messages. There was a bug in isolinear - fixed in revery-ui/isolinear#14 - that meant, if a subscription held on to the `dispatch` in its `init` / `update` (which is common when you have a promise-based request) - it could still trigger a dispatch after it had been disposed. __Fix:__ Addressed in revery-ui/isolinear#14, but we could also remove a workaround that was used (a `Latch.t`) in places where it was particularly problematic.
onivim · Sep 24, 2020 · b6e2388 · b6e2388
1 parent cb8042b
commit b6e2388
Show file tree

Hide file tree

Showing 15 changed files with 212 additions and 289 deletions.
diff --git a/bench.esy.lock/index.json b/bench.esy.lock/index.json
diff --git a/bench.esy.lock/opam/topkg.1.0.2/opam → bench.esy.lock/opam/topkg.1.0.3/opam b/bench.esy.lock/opam/topkg.1.0.2/opam → bench.esy.lock/opam/topkg.1.0.3/opam
diff --git a/esy.lock/index.json b/esy.lock/index.json
diff --git a/esy.lock/opam/topkg.1.0.2/opam → esy.lock/opam/topkg.1.0.3/opam b/esy.lock/opam/topkg.1.0.2/opam → esy.lock/opam/topkg.1.0.3/opam