fix(input/#2114): Handle nnoremap correctly
#2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bryphe
added a commit
that referenced
this pull request
Jan 1, 2021
Fixes #2883 __TODO:__ - [x] Make use of our new keyboard layout module (thanks @zbaylin !) - [x] Bring back special-key handling - [x] Add test case for #2883 - [x] Fix scancodes / verify 'AllKeysReleased' behavior for Control+Tab - [x] Fix bug with C-C / C-D / C-U being forwarded to Vim - [x] Fix newly introduced bug with Control+Shift+P/Cmd+Shift+P __Next steps:__ - #2114 - respect 'no recursive' flag for remaps (#2908) - #2293 - Update the `keyDown` function in `EditorInput` to take a list of candidates as opposed to a single keypress. - #2293 - Enable some bindings that were previously blocked: - `<C-W>+` - `<C-W>_` - `<C-W>|` - Refactor input event subscription and `Sld2.TextInput.start` out of store and into a `Service_Input` sub - Move `input` utility to common integration test infrastructure - Remove the `KeyboardInput` Action
bryphe
force-pushed
the
fix/input/2114/no-recursive-flag
branch
from
112f29c
to
c52e260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: All of our bindings, whether defined by
nmapornnoremap, were allowing recursive definitions. This breaks the case in #2114, where the remaps would bounce back and forth until they hit our recursion limit.Defect: We weren't gating recursive remaps, aside from the recursion limit.
Fix: Define and handle no-recursive remaps correctly.
Todo:
Fixes #2114
Depends on #2883
Related #1551