fix(codelens): Handle $emitCodeLens event #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The codelens feature for the VersionLens plugin wasn't showing up until the editor is scrolled.
Defect: Some extensions, like VersionLens will change codelens on the fly, or via a command, and they would message that to the editor via the exthost
$emitCodeLensevent. We weren't handling this event, so we didn't know to refresh the codelens.Fix: Handle the
$emitCodeLensevent, wire up to the provider / subscription via aneventTickproperty - always refresh the subscription when that property changes.This fix enables the VersionLens plugin:
Related #1058