Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vim/#2968): Cursor management in command-line mode #3020

Merged
merged 10 commits into from
Jan 20, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 20, 2021

Issue: There were a couple related issues with the cursor in command-line mode:

  1. When exiting command-line mode, the cursor could 'flash' at the top of the file
  2. When running a search command, the viewport would not scroll to the first match

Defect: Both issues stem from the fact that Onivim was ignoring editor-cursor-position changes during search.

For the first issue, when exiting command-line mode, there would be a brief transitional state where the editor is focused in CommandLine mode, but no cursor would be available - so it would be rendered at the default (0,0) position. This would be rectified once the mode transition completed and the cursor position is reset.

For the second issue, libvim was properly updating the cursor position when searching, but that cursor position was being ignored.

Fix: Track the editor cursor position during the course of the command-line interaction

Fixes #2968
Related #1551

@bryphe bryphe merged commit b6f1cc6 into master Jan 20, 2021
@bryphe bryphe deleted the fix/vim/2968/cursor-flicker branch January 20, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small cursor flicker when entering command.
1 participant