Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent UX #4222

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Ensure consistent UX #4222

merged 3 commits into from
Mar 7, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Mar 6, 2025

Description

  • Consistent icons + minor dark mode nit
Screenshot 2025-03-06 at 1 04 26 PM

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@pablonyx pablonyx requested a review from a team as a code owner March 6, 2025 21:07
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 9:45pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored LLM provider icon mapping and enhanced FilterComponent styling for improved visual consistency across the application.

  • Simplified icon mapping in /web/src/app/admin/configuration/llm/interfaces.ts with direct provider lookups, but removed support for 'bedrock' and 'azure' providers
  • Added dark mode support for SortIcon in /web/src/app/admin/indexing/status/FilterComponent.tsx with dark:text-neutral-200 class
  • Enforced consistent Badge styling with !important modifiers for background and border colors
  • Improved icon fallback logic to check both provider name and model name before defaulting to CPU icon

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@evan-danswer evan-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablonyx pablonyx enabled auto-merge March 6, 2025 21:42
@pablonyx pablonyx disabled auto-merge March 6, 2025 21:42
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@Weves Weves added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit bf4983e Mar 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants