GitHub Pages Connector #4233
Open
GitHub Pages Connector #4233
+367
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akhilender-bongirwar is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a new GitHub Pages connector to index content from GitHub Pages sites, implementing direct GitHub API integration with rate limiting and error handling.
- Missing
osimport ingithub_pages/connector.pybut usingos.pathfunctions doc_updated_atuses current time instead of file's last modified time in_process_file- No validation for file size or recursion depth in
_get_all_filestraversal - Python version change from 3.11 to 3.12 in pre-commit config creates inconsistency with CI pipeline
- Connector config lacks advanced settings like branch selection or path filtering
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
10 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
backend/tests/daily/connectors/github_pages/test_github_pages_connector.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Akhilender Bongirwar <[email protected]>
akhilender-bongirwar
force-pushed
the
feat/add-connector-gh-pages
branch
from
6e1b30b to
a5dc6d5
Compare
|
@yuhongsun96 please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a connector for GitHub Pages.
fixes #2282
2025-03-08.22-11-35.mp4