Eliminate extremely long log line for large checkpointds #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a string representation method to ConnectorCheckpoint class to truncate long checkpoint content in logs, improving log readability and reducing log spam.
- Added
__str__method in/backend/onyx/connectors/models.pywith 1000 character limit for checkpoint content - Implemented truncation with '...' suffix for content exceeding the limit
- Maintains checkpoint information visibility while preventing excessive log line length
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
backend/onyx/connectors/models.py
Outdated
| """String representation of the checkpoint, with truncation for large checkpoint content.""" | ||
| MAX_CHECKPOINT_CONTENT_CHARS = 1000 | ||
|
|
||
| content_str = str(self.checkpoint_content) |
There was a problem hiding this comment.
logic: Converting checkpoint_content directly to string could fail for complex objects. Consider using json.dumps() for reliable serialization
rkuo-danswer
approved these changes
Mar 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
^
Log is here: https://github.com/danswer-ai/danswer/blob/main/backend/onyx/background/indexing/run_indexing.py#L430-L432
How Has This Been Tested?
Tested indexing locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.