Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): 1.0.0-alpha #41

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

refactor(core): 1.0.0-alpha #41

wants to merge 42 commits into from

Conversation

ElijahKotyluk
Copy link
Member

@ElijahKotyluk ElijahKotyluk commented Apr 14, 2021 •
edited
Loading

@onyx/core package rewrite for alpha release

@ElijahKotyluk ElijahKotyluk requested a review from dsseng April 14, 2021 07:16
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #41 (7e794f5) into master (09b4ce5) will increase coverage by 2.08%.
The diff coverage is n/a.

❗ Current head 7e794f5 differs from pull request most recent head 403cd68. Consider uploading reports for the commit 403cd68 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master       #41      +/-   ##
===========================================
+ Coverage   97.91%   100.00%   +2.08%     
===========================================
  Files          27         1      -26     
  Lines         383        26     -357     
  Branches       69         7      -62     
===========================================
- Hits          375        26     -349     
+ Misses          7         0       -7     
+ Partials        1         0       -1
Impacted Files Coverage Δ
packages/core/src/result.ts 100.00% <0.00%> (ø)
packages/core/src/hooks.ts
packages/matchers/src/toThrow.ts
packages/matchers/src/toBeTypeOf.ts
packages/matchers/src/toBeDefined.ts
packages/matchers/src/toHaveLength.ts
packages/core/src/interface.ts
packages/matchers/src/toBeNull.ts
packages/matchers/src/matchers.ts
packages/matchers/src/toBeNaN.ts
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6264b16...403cd68. Read the comment docs.

@ElijahKotyluk ElijahKotyluk added the work in progress A work in progress label Apr 14, 2021
dsseng
dsseng reviewed Apr 15, 2021
View reviewed changes
packages/core/test/runner.spec.ts
import { Status } from '../src/result'
import Runnable from '../src/runnable'
import Runner, { normalizeRunOptions, RunOptions } from '../src/runner'
//import { Status } from '../src/result'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it all commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am rethinking the Runner class entirely. I am aiming for generator + co-routines.

ElijahKotyluk added 15 commits May 4, 2021 01:06
@ElijahKotyluk
chore(suite): fix spacing.
efa4c18
@ElijahKotyluk
Merge branch 'master' into refactor/core-v1-alpha
7175f70
@ElijahKotyluk
test(test): clear timers at end of timeout test.
bcc4f4a
@ElijahKotyluk
chore(test-spec): update comment for timeout test.
34d860d
@ElijahKotyluk
fix(test): remove await from fn when racing promise against timeout.
bbfa7a0
@ElijahKotyluk
refactor(runnable): make runnable an abstract class, remove events an…
74f1c54 
…d event emitter.
@ElijahKotyluk
test(runnable): start testing abstract class.
6893b76
@ElijahKotyluk
refactor(runnable): update runnable class and tests. Update result ty…
403cd68 
…pes used.
@ElijahKotyluk
refactor(runnable): make doFail always take an error.
a3b3c94
@ElijahKotyluk
Merge branch 'master' into refactor/core-v1-alpha
a540717
@ElijahKotyluk
chore(core): misc changes.
df63892
@ElijahKotyluk
Merge branch 'refactor/core-v1-alpha' of github.com:onyxjs/onyx into …
7e3b2c4 
…refactor/core-v1-alpha
@ElijahKotyluk
chore(configs): update ts and jest.
77e357c
@ElijahKotyluk
refactor(test): rewrite test class, runnable class, and tests. Commen…
fb7e5a0 
…t out old files.
@ElijahKotyluk
test(core): skip files that have not been refactored.
a8d7757
@ElijahKotyluk
refactor(test): rewrite test class.
3bb9ff9
@ElijahKotyluk
refactor(suite): rewrite run method.
4eda7c3
@ElijahKotyluk
chore(core): remove utils.ts and types.ts.
097457c
@ElijahKotyluk
feat(utils): add utils.
554c493
@ElijahKotyluk
feat(errors): add internal error classes.
844363c
@ElijahKotyluk
feat(types): add types directory.
1abd6bd
@ElijahKotyluk
chore(snapshots): remove old snapshots.
3fbd310
@ElijahKotyluk
chore(core): WIP, circular dependencies from core class imports.
384b73b
@ElijahKotyluk
fix(suite): export isSuite and rootSymbol.
d5fecdc
@ElijahKotyluk
test(Test): fix should fail.
0200e16
@ElijahKotyluk
feat(runnable): add isStatus method.
6085412
@ElijahKotyluk
refactor(result): remove properties, update addErrors method.
45ec3b3
@ElijahKotyluk
refactor(runnable): add isPending method, update concatenated return …
aeff41d 
…from getFullDescription.
@ElijahKotyluk
refactor(result): make result type generic based on test type. add cr…
da35643 
…eateResult function.
@ElijahKotyluk
test(result): reintroduce result class tests.
e4e5e68
@ElijahKotyluk
Merge branch 'master' into refactor/core-v1-alpha
41e63a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsseng dsseng dsseng left review comments

Assignees
No one assigned
Labels
work in progress A work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElijahKotyluk @dsseng