Skip to content

Commit

Permalink
add github action for oonifindings tests
Browse files Browse the repository at this point in the history
  • Loading branch information
DecFox committed May 8, 2024
1 parent 2d8946e commit 5ce564e
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 2 deletions.
25 changes: 25 additions & 0 deletions .github/workflows/test_ooniapi_oonifindings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: test ooniapi/oonifindings
on: push
jobs:
run_tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Set up Python 3.11
uses: actions/setup-python@v4
with:
python-version: 3.11

- name: Install hatch
run: pip install hatch

- name: Run all tests
run: make test-cov
working-directory: ./ooniapi/services/oonifindings/

- name: Upload coverage to codecov
uses: codecov/codecov-action@v3
with:
flags: oonifindings
working-directory: ./ooniapi/services/oonifindings/
4 changes: 2 additions & 2 deletions ooniapi/services/oonifindings/src/oonifindings/routers/v1.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def list_oonifindings(
)
if only_mine:
if account_id is None:
return OONIFindings(incidents=[])
return OONIFindingIncidents(incidents=[])
where += "\nAND creator_account_id = %(account_id)s"

if account_id is None:
Expand Down Expand Up @@ -196,7 +196,7 @@ def list_oonifindings(
mine=account_id == incident.creator_account_id,
)
incident_models.append(incident_model)
return OONIFindings(incidents=incident_models)
return OONIFindingIncidents(incidents=incident_models)


@router.get(
Expand Down

0 comments on commit 5ce564e

Please sign in to comment.