Skip to content

Commit

Permalink
Add note about web_analysis
Browse files Browse the repository at this point in the history
  • Loading branch information
hellais committed Jan 20, 2025
1 parent 48dd4aa commit 3d4a624
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions oonipipeline/src/oonipipeline/analysis/web_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ def format_query_analysis_web_fuzzy_logic(
-- We didn't get a good DNS answer, so we can't do much to analyze this result set since we
-- can't trust what we saw in DNS, so we just return early and ignore this from the perspective of
-- a TCP analysis
-- TODO(art): since this being applied after the first check for success, we
-- run the risk of marking as OK TCP instances where we were able to connect to the blockpage.
-- It it correct to do so?
dns_blocked > 0 AND dns_ok <= (dns_blocked + dns_down),
tuple(0, 0, 0),
Expand Down

0 comments on commit 3d4a624

Please sign in to comment.