Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing echcheck related metadata in pipeline #108

Closed
hellais opened this issue Jan 17, 2025 · 1 comment
Closed

Add support for parsing echcheck related metadata in pipeline #108

hellais opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels

Comments

@hellais
Copy link
Member

hellais commented Jan 17, 2025

We have added a new test called echcheck that's shipped since November 2024 in all probes, see: https://github.com/ooni/spec/blob/master/nettests/ts-039-echcheck.md.

Currently the data pipeline doesn't support parsing this new test. We should do that by implementing a new model for the test (see: https://github.com/ooni/data/blob/main/oonidata/src/oonidata/models/nettests/web_connectivity.py) and then adding a transformed to fill out the tls_echconfig field: https://github.com/ooni/data/blob/main/oonidata/src/oonidata/models/observations.py#L287 in here: https://github.com/ooni/data/blob/main/oonipipeline/src/oonipipeline/transforms/nettests/web_connectivity.py and then adding it to the transforms list: https://github.com/ooni/data/blob/main/oonipipeline/src/oonipipeline/transforms/observations.py#L43.

An example on how this is done can be seen in this PR: #50.

Note: since then some slight changes to the structure of this repo might have changed, but the core logic stays more or less the same.

@hellais hellais added this to Roadmap Jan 17, 2025
@hellais hellais moved this to Sprint Backlog in Roadmap Jan 17, 2025
@hynnot hynnot moved this from Sprint Backlog to In Progress in Roadmap Jan 20, 2025
@hynnot hynnot moved this from In Progress to Review/QA in Roadmap Jan 24, 2025
@hellais
Copy link
Member Author

hellais commented Jan 24, 2025

This is done

@hellais hellais closed this as completed Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Roadmap Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants