Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing echcheck related metadata in pipeline #115

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

hynnot
Copy link
Contributor

@hynnot hynnot commented Jan 23, 2025

Issue #108

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (853ada2) to head (22f3e49).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...e/src/oonipipeline/transforms/nettests/echcheck.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   82.21%   82.58%   +0.37%     
==========================================
  Files          69       71       +2     
  Lines        4166     4227      +61     
==========================================
+ Hits         3425     3491      +66     
+ Misses        741      736       -5     
Flag Coverage Δ
oonidata 77.50% <100.00%> (+0.24%) ⬆️
oonipipeline 86.85% <95.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hynnot hynnot force-pushed the add-support-for-parsing-echcheck branch from e45e959 to 22f3e49 Compare January 23, 2025 14:48
@hynnot hynnot requested a review from hellais January 23, 2025 15:01
@hynnot hynnot marked this pull request as ready for review January 24, 2025 08:39
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for putting it together. Merging.

@hellais hellais merged commit 0574fc0 into main Jan 24, 2025
9 checks passed
@hellais hellais deleted the add-support-for-parsing-echcheck branch January 24, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants