Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hourly runs and reprocessing #112

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Add support for hourly runs and reprocessing #112

merged 8 commits into from
Jan 24, 2025

Conversation

hellais
Copy link
Member

@hellais hellais commented Jan 20, 2025

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 94.26230% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (4058e3f) to head (e65dd55).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
oonipipeline/src/oonipipeline/cli/commands.py 82.75% 5 Missing ⚠️
oonidata/src/oonidata/dataclient.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   82.21%   82.72%   +0.50%     
==========================================
  Files          69       70       +1     
  Lines        4166     4248      +82     
==========================================
+ Hits         3425     3514      +89     
+ Misses        741      734       -7     
Flag Coverage Δ
oonidata 77.62% <92.30%> (+0.36%) ⬆️
oonipipeline 86.91% <94.79%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellais hellais changed the title Add support for listing files in s3 by hour Add support for hourly runs and reprocessing Jan 23, 2025
@hellais hellais marked this pull request as ready for review January 23, 2025 19:47
@hellais hellais requested a review from hynnot January 23, 2025 19:47
@hellais
Copy link
Member Author

hellais commented Jan 23, 2025

This should be now ready for review and it's quite important we land it soon to address this bug that came out: #116

@hynnot
Copy link
Contributor

hynnot commented Jan 24, 2025

LGTM!

@hellais hellais merged commit 36a9819 into main Jan 24, 2025
9 checks passed
@hellais hellais deleted the hourly-runs branch January 24, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reduce observation generation frequency to hourly Come up with a better way of running reprocessing of data
2 participants