Add new jwt_secret for ooniprobe service #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After talking with @hellais we realized that we still need to use the same token for all services. So we have to take a different approach, for now we will rely on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to this PR in backend: ooni/backend#923
We have to add a new
jwt_secretencryption key for ooniprobe, since the current ooniprobe service provides toy login tokens without authentication. If we don't use a different encryption key, you can get a session token from ooniprobe that can be used in ooniauth to login without authentication.Note: For this PR to work we have to create the key in Parameter Storage in AWS