[New Designs] Update Run button from dashboard to display new flow for selecting desired tests #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle-kotlin-upgrade
bassosimone
suggested changes
Nov 21, 2023
app/src/main/java/org/openobservatory/ooniprobe/activity/runtests/RunTestsActivity.kt
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/runtests/RunTestsActivity.kt
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/runtests/RunTestsActivity.kt
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/runtests/RunTestsActivity.kt
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| private fun updateStatusIndicator() { | ||
| //TODO(aanorbel): translate status indicator |
There was a problem hiding this comment.
Do we want to do this in the same PR or in a subsequent one?
app/src/main/java/org/openobservatory/ooniprobe/test/suite/InstantMessagingSuite.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/test/suite/MiddleBoxesSuite.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/test/suite/PerformanceSuite.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/test/test/AbstractTest.java
Outdated
Show resolved
Hide resolved
…nceManagerExtension.kt Co-authored-by: Simone Basso <[email protected]>
bassosimone
reviewed
Dec 8, 2023
| String tn, | ||
| @Nullable List<String> urls, | ||
| String origin) { | ||
| for (AbstractSuite suite : TestAsyncTask.getSuites()) |
There was a problem hiding this comment.
Please, always use { and } even if there is just a single statement afterwards.
bassosimone
reviewed
Dec 8, 2023
| for (AbstractSuite suite : TestAsyncTask.getSuites()) | ||
| for (AbstractTest test : suite.getTestList(app.getPreferenceManager())) | ||
| if (test.getName().equals(tn)) { | ||
| if (urls != null) |
bassosimone
reviewed
Dec 8, 2023
| import org.openobservatory.engine.BaseDescriptor | ||
| import org.openobservatory.engine.BaseNettest | ||
|
|
||
| class ChildItem( |
There was a problem hiding this comment.
maybe name this ChildGroupItem?
bassosimone
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ooni/probe#2589
build: https://github.com/ooni/probe-android/suites/18778645278/artifacts/1094292643
Proposed Changes
RunTestsActivityand related components