Control preset possibility and shield powerup implementation #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified InputHandler::Binding, to handle preset storage modified every code using InputHandler::Binding modified InputHandler::getKeyName function and every usage modified Configuration::ReadPlayerBinding to read multiple presets modified Configuration::ReadPlayerBinding to write multiple presets modified InputHandler::processEvent to check every preset for match created macro to define number of presets removed code regarding hardwired number of presets (TODO except the switch statement for preset increment) set number of presets to 2
changed hud msg accordingly
modifications are made to store preset configurations modified InputHandler::Binding, to handle preset storage modified every code using InputHandler::Binding modified InputHandler::getKeyName function and every usage modified Configuration::ReadPlayerBinding to read multiple presets modified Configuration::ReadPlayerBinding to write multiple presets modified InputHandler::processEvent to check every preset for match created macro to define number of presets removed code regarding hardwired number of presets (TODO except the switch statement for preset increment) set number of presets to 2
|
Hello, sry for the late reply. I reordered the commits and moved some unnecessarry ones to a different branch. Now how do I make a pull request from earlier commits? If you could help with this I would gladly create the 2 pull requests for the distinct features. Thanks in advance, |
|
I created 2 separate PRs, tell me if I need to make some more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the control preset option (possibility to use multiple kay mapping) to make it possibly to have a controller preset as well. That is a bit stalled...
I also created a shield power up, with icon and some animation.