V2 #9
Open
V2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More info [here](http://editorconfig.org/).
More info [here](https://github.com/bbatsov/rubocop).
|
Oh, I see that the last maintainer @cespare is Go-developer now. Maybe, this repo need for a new collaborator? I can be it. |
sunny
reviewed
Apr 12, 2020
Drop support of Ruby 2.3 and below. RuboCop 0.82 requires 2.4, also their support has been ended: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
Make them more readable and flexible.
Use `Retries` instance for state. Don't patch `Kernel` module. Replace `Retries.sleep_enabled` with `Retries.options` (Hash with defaults).
Resolve RuboCop offenses.
Resolve new offenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's about rewriting almost everything, excepting exponential backoff, but including public API.
I'll understand if you will not accept this PR. But I want to try. 🙂
If you have any questions, why I changed public API or removed
redcarpetdependency — I can answer (but I've already tried in commit messages).P.S. This PR includes changes from #7.