Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Run client + host workflow on 32 bit platform #907

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 15, 2025

Closes #849

@emhane emhane added the A-ci Area: CI label Jan 15, 2025
@emhane emhane requested review from clabby and refcell as code owners January 15, 2025 13:08
@emhane emhane marked this pull request as draft January 15, 2025 13:09
@emhane emhane force-pushed the emhane/32-bit-platform branch from 9618760 to bc505b2 Compare January 15, 2025 13:09
@emhane
Copy link
Member Author

emhane commented Jan 15, 2025

seems like no runner wants to pick up this job...

Requested labels: linux-ubuntu-latest-32bit
Job defined at: op-rs/kona/.github/workflows/client_host.yaml@refs/pull/907/merge
Waiting for a runner to pick up this job...
Requested labels: linux-ubuntu-latest-32bit
Job defined at: op-rs/kona/.github/workflows/client_host.yaml@refs/pull/907/merge
Waiting for a runner to pick up this job...

@emhane emhane force-pushed the emhane/32-bit-platform branch 2 times, most recently from 339843a to ecd8825 Compare January 15, 2025 14:19
@emhane emhane force-pushed the emhane/32-bit-platform branch from ecd8825 to e34c218 Compare January 15, 2025 14:32
@emhane
Copy link
Member Author

emhane commented Jan 15, 2025

not sure why the syntax isn't being parsed, feel free to take over

The workflow is not valid. .github/workflows/client_host.yaml (Line: 18, Col: 9): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.isa == '32'

@refcell
Copy link
Collaborator

refcell commented Jan 16, 2025

It appears this won't work because github actions checkout steps require a node version only available in 64 bit builds.

@emhane
Copy link
Member Author

emhane commented Jan 16, 2025

ah ok, I was looking at this https://github.com/yuki-kimoto/SPVM-Regex/blob/master/.github/workflows/linux-ubuntu-latest-32bit.yml @refcell

@clabby
Copy link
Collaborator

clabby commented Jan 17, 2025

It looks like @refcell's fix does the trick, but the image we're using does not have all of the tools that are preloaded into GitHub's runner-images. To complete this I think we'd need to add an extra step to install all required dependencies when running with the i386/ubuntu base.

@emhane
Copy link
Member Author

emhane commented Jan 18, 2025

ah I thought rustc was clever enough to infer the target in this case. is that what you mean? @clabby

@clabby
Copy link
Collaborator

clabby commented Jan 19, 2025

ah I thought rustc was clever enough to infer the target in this case. is that what you mean? @clabby

Ah nope - this isn't to do with rustc, the image that the actual runner is executing the job on doesn't have the tools that are required. GitHub's runner images come pre-loaded with a bunch of stuff (gnu utils, docker, nodejs, etc.) that this new i386 image doesn't have.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (8e25874) to head (1fecb59).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ci): Build and test on 32-bit platforms
3 participants