Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host): Modular components #915

Merged
merged 6 commits into from
Jan 22, 2025
Merged

feat(host): Modular components #915

merged 6 commits into from
Jan 22, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 22, 2025

Overview

Cleans up some of the duplication in the host by tackling #369. The host's preimage server is now served with generics over the Fetcher + communication Channel. The HostOrchestrator trait allows for creating a custom host program with its own CLI with most of the bootstrapping auto-implemented.

These abstractions are also used in the kona-host binary now, sharing a ton more code between the single-chain and interop modes.

@clabby clabby added A-host Area: host binary K-feature Kind: feature labels Jan 22, 2025
@clabby
Copy link
Collaborator Author

clabby commented Jan 22, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@clabby clabby self-assigned this Jan 22, 2025
@clabby clabby linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (c56c3fc) to head (a6258a0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review January 22, 2025 02:38
@clabby clabby requested review from refcell and emhane as code owners January 22, 2025 02:38
@emhane emhane added the H-interop Hardfork: Interop related label Jan 22, 2025
bin/host/src/main.rs Outdated Show resolved Hide resolved
@clabby clabby added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 80b9c44 Jan 22, 2025
16 checks passed
@clabby clabby deleted the cl/host-lib branch January 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary H-interop Hardfork: Interop related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(host): fetcher builder to customize hint types & implementations
3 participants