Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(executor): Remove anyhow dev-dependency #937

Merged
merged 1 commit into from
Jan 22, 2025
Merged

chore(executor): Remove anyhow dev-dependency #937

merged 1 commit into from
Jan 22, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 22, 2025

Overview

Removes anyhow as a dev-dependency of kona-executor

closes #920

@clabby clabby requested review from refcell and emhane as code owners January 22, 2025 17:54
@clabby clabby added A-executor Area: kona-executor crate K-chore Kind: chore labels Jan 22, 2025
@clabby clabby self-assigned this Jan 22, 2025
@clabby
Copy link
Collaborator Author

clabby commented Jan 22, 2025 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (bf87631) to head (9478090).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/rm-anyhow-executor branch from b27647c to cb18ffc Compare January 22, 2025 17:58
@clabby clabby mentioned this pull request Jan 22, 2025
Merged
@clabby clabby force-pushed the cl/rm-anyhow-executor branch from cb18ffc to 9478090 Compare January 22, 2025 20:34
@clabby clabby enabled auto-merge January 22, 2025 20:40
@clabby clabby added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit f4d4e23 Jan 22, 2025
16 checks passed
@clabby clabby deleted the cl/rm-anyhow-executor branch January 22, 2025 20:49
This was referenced Jan 22, 2025
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-executor Area: kona-executor crate K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(executor): Remove anyhow dev-dependency
2 participants
@clabby @refcell