Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(executor): TxEnv Stuffing #970

Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore(executor): TxEnv Stuffing #970

merged 1 commit into from
Jan 28, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jan 28, 2025

Description

Fixes tx env stuffing in the executor contract calls.

Closes #950

@refcell refcell self-assigned this Jan 28, 2025
@refcell refcell requested review from clabby and emhane as code owners January 28, 2025 19:44
@refcell
Copy link
Collaborator Author

refcell commented Jan 28, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell added K-chore Kind: chore A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related labels Jan 28, 2025
@refcell refcell changed the title fix(executor): TxEnv Stuffing chore(executor): TxEnv Stuffing Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 73.13433% with 18 lines in your changes missing coverage. Please review.

Project coverage is 88.7%. Comparing base (882a71e) to head (aa7d9eb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/syscalls/eip2935.rs 0.0% 6 Missing ⚠️
crates/executor/src/syscalls/eip7002.rs 0.0% 6 Missing ⚠️
crates/executor/src/syscalls/eip7251.rs 0.0% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 19eef57 Jan 28, 2025
15 of 16 checks passed
@clabby clabby deleted the rf/tx-env-stuffing branch January 28, 2025 20:10
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
This was referenced Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(executor): Pectra system calls
2 participants