Let ChatQnA support authorized LLM service. #1273
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yugar-1 <[email protected]>
Yugar-1
requested review from
lvliang-intel,
ftian1,
letonghan,
XinyaoWa and
Spycsh
as code owners
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
eero-t
reviewed
Feb 10, 2025
There was a problem hiding this comment.
If bearer token is not specified, I think it would be more robust to skip sending it, rather than sending an invalid (EMPTY) one.
Authorization RFC recommends transmitting bearer token only over secured connection: https://datatracker.ietf.org/doc/html/rfc6750#section-5.3
So maybe this should check the connection protocol and given an error, if bearer token is given over unsecured connection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Let ChatQnA support authorized LLM service.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Fix: opea-project/GenAIExamples#1453
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.