Remove factors input from rsa() and use scenario dataframe column names instead
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er exists, to be updated shortly in another PR)
|
The changes look good to me. It appears that the tests are still unable to finish due to an error in the sampling test cases. Is this completely unrelated? Resulting from line 516 in io/sampling.jl in set_factor_bounds params[params.fieldname .== factor, :val] .= oftype(old_val, new_val) |
Hmm weird, they passed for me... I'll have a look |
|
I ran tests again and they still all passed, you're definitely on |
DanTanAtAims
approved these changes
Feb 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #692
Note: Tests for
outcome_map()have been commented out as this function now refers to a function which no longer exists. This will be resolved shortly when addressing #615