fix: ensure operation_id is always set on conn.private #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
commented
May 13, 2024
| @@ -78,6 +78,7 @@ defmodule OpenApiSpex.Plug.CastAndValidate do | |||
| ) do | |||
| {spec, operation_lookup} = PutApiSpec.get_spec_and_operation_lookup(conn) | |||
| operation = operation_lookup[operation_id] | |||
| conn = put_operation_id(conn, operation) | |||
There was a problem hiding this comment.
This was getting dropped when an error during casting occurred. Even though we set it, the error handling returned a stale conn so it wouldn't pass through. Lifting this up top ensures that it's always there for all success/error cases.
msutkowski
changed the title
msutkowski
commented
May 13, 2024
mbuhot
approved these changes
May 15, 2024
|
Thanks @msutkowski ! |
nathanalderson
pushed a commit
to Tango-Tango/open_api_spex
that referenced
this pull request
Dec 20, 2024
…#606) * fix: ensure operation_id is always set on conn.private when an operation is known
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where you had to pass in the
operationIdon error cases toassert_operation_responsebecause of the nature of the error handling halting and returning a collection of errors for the given step. Lifting theput_operation_idup gets around all of that as even if thingshalt, we'll still have a reference to the operationId inconn.private