Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver) (AGH eng. project by Michał Kowalczyk @Caastlefox) #495

Merged
merged 53 commits into from
Jan 29, 2025

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jan 5, 2025

No description provided.

@slayoo
Copy link
Member Author

slayoo commented Jan 5, 2025

@Caastlefox, not to forget:

  • label for the colorscale (temperature [K])
  • brief description of what equations are solved, and where the settings originate from
  • @jit decorator for more functions
  • at least a minimal smoke test

To fix the precommit formatting issue, you need to pip install pre-commit, and then either do pre-commit install (which will trigger pre-commit formatting changes before each commit) or trigger the scan manually with pre-commit run --all-files. HTH

@Caastlefox Caastlefox force-pushed the development branch 3 times, most recently from bf0ee03 to 7fa6b92 Compare January 6, 2025 10:54
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (ddecbf2) to head (d98e06f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          30       30           
  Lines        1466     1466           
=======================================
  Hits         1349     1349           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo changed the title new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver); devops tests bump new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver) (AGH eng. project by Michał Kowalczyk @Caastlefox) Jan 29, 2025
@slayoo slayoo merged commit e401d7e into open-atmos:main Jan 29, 2025
34 checks passed
@slayoo
Copy link
Member Author

slayoo commented Jan 29, 2025

kudos @Caastlefox !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants