GH-73 Add context modifier to CoapRequest

[szysas]

No description provided.

[szysas]

@sbernard31 would that work for you? Very simple addition to support context modifier.

[sbernard31]

It could do the job but during this conversation (#68 (comment)), I understood that with*** method was mainly temporary solution.

So maybe we can directly go with a more future proof changes ?
Like :

coapRequest.modify()
           .context(ctx -> ctx.with(key,value))
           .build();

Where modify will be :

public final class CoapRequest {
  // ...

  public CoapRequest.Builer modify() {
    return new CoapRequest.Builer(this);
  }

  // ...

  public static class Builder {
    private Builder(CoapRequest coapRequest) {
            this.method = coapRequest.method;
            this.options = CoapOptionsBuilder.from(coapRequest.options);
            ... 
            ...
            this. transContext = coapRequest.transContext; 
    }
  }
}

I mean we add this modify method but you keep the existing with** methods and you will deprecated/remove it when you think this will be the right moment.

[szysas]

You're right, going directly to .modify() function is a better option.
How about now?

[sbernard31]

Yep it sounds good. 👍

So to add a entry in transport context of a request, this will look like :

coapRequest.modify()
           .context(key,value)
           .build();

Do we need to add this methods to builder ?

public Builder context(Consumer<TransportContext> contextFunc) {
    contextFunc.apply(transport);
    return this;
}

That was my initial idea but thinking a bit more about it I think this is not really needed. Any opinion ?

[szysas]

I don't think it is needed, anyway we can always add it later.