Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(address-service): add script to create address #5699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crowncode-development
Copy link
Contributor

A script for adding an address to the local-address-service database via the console in the absence of providers

Copy link
Member

@SavelevMatthew SavelevMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your interest in the project. There are 2 things that confuse me about this PR:

  1. Why is there no city / town in the address?
  2. We try not to stitch country-specific data into the Open-Source part of the project, as this makes it impossible to launch it outside of those countries.

We also try to avoid adding unnecessary scripts to bin, at the current time I don't really understand what this script is for.

  1. If it is intended for local development, it should be called generate-address, and inside use faker without country-specific binding (or pass the country as an argument and change the logic a bit, if necessary).
  2. If it is not intended for local development, why addresses are added without city and without addressMeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants