doma-9987 synchronization template #5767

Alexander-Turkin · 2025-02-05T10:46:50Z

add emoji, add symbols of transfer, add receiving template

…from query

apps/condo/domains/news/components/NewsForm/BaseNewsForm.tsx

toplenboren · 2025-02-06T10:21:59Z

apps/condo/domains/news/components/NewsForm/CreateNewsForm.tsx

@@ -191,8 +191,8 @@ export const CreateNewsForm: React.FC = () => {
    const templates = isNewsItemTemplatesFetching || !newsItemTemplates?.length ? null : newsItemTemplates
        .reduce((acc, template) => {
            acc[template.id] = {
-                title: template.title,
-                body: template.body,
+                title: template.title.replace(/<\/br>/g, '\n'),


Why do you need this logic?

I replaced the /n on
templates because when sending the transfer symbol is shielded, well, here you need to return it

why not just use url encoding?

apps/condo/domains/news/components/TemplatesSelect.tsx

toplenboren · 2025-02-06T10:24:15Z

apps/condo-news-greenhouse

I think u need to rebase :-) strange that u add a new submodule, u should be just updating one added by @sitozzz

review changes Co-authored-by: Mikhail Gorbunov <[email protected]>

This reverts commit c6cf4de.

This reverts commit 00cdde8.

toplenboren · 2025-02-07T09:31:58Z

apps/condo/domains/news/components/NewsForm/BaseNewsForm.tsx

@@ -1462,6 +1466,7 @@ export const BaseNewsForm: React.FC<BaseNewsFormProps> = ({
                                    (getStepTypeByStep(currentStep) === 'sharingApp') && (
                                        // TODO (DOMA-9328) Move onSkip to BaseNewsForm component, since steps are handled here!
                                        <NewsItemSharingForm
+                                            template={{ id: templateId, ...templates[templateId] }}


why not just ...templates[templateId] ?

toplenboren · 2025-02-07T09:32:22Z

apps/condo/domains/news/components/NewsForm/CreateNewsForm.tsx

@@ -191,8 +191,8 @@ export const CreateNewsForm: React.FC = () => {
    const templates = isNewsItemTemplatesFetching || !newsItemTemplates?.length ? null : newsItemTemplates
        .reduce((acc, template) => {
            acc[template.id] = {
-                title: template.title,
-                body: template.body,
+                title: template.title.replace(/<\/br>/g, '\n'),


why not just use url encoding?

apps/condo/domains/news/components/TemplatesSelect.tsx

…his case

toplenboren · 2025-02-10T09:41:05Z

apps/condo/domains/news/components/NewsForm/NewsItemSharingForm.tsx

@@ -1,4 +1,4 @@
-import { B2BApp } from '@app/condo/schema'
+import { B2BApp, NewsItemTemplateTypeType } from '@app/condo/schema'


why TypeType?

apps/condo/domains/news/schema/NewsItemTemplate.test.js

toplenboren · 2025-02-10T09:42:23Z

apps/condo/domains/news/components/NewsForm/BaseNewsForm.tsx

@@ -621,7 +621,11 @@ export const BaseNewsForm: React.FC<BaseNewsFormProps> = ({
        Body.setTextLength(initialBody.length)
    }, [])

+    const [templateId, setTemplateId] = useState('')


I think when dealing with Ids its more clean to make values null || string

Co-authored-by: Mikhail Gorbunov <[email protected]>

Alllex202 · 2025-02-10T10:20:51Z

apps/condo/domains/news/schema/NewsItemTemplate.js

+            hooks: {
+                resolveInput: async ({ resolvedData }) => {
+                    return normalizeText(resolvedData['title'])
+                },
+            },


Do we need to do same for the name field?

no, field is used in the selector

I see this type for the name field: Text, not Select

This means that users can write anything there

sonarqubecloud · 2025-02-10T18:23:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Alexander-Turkin added 4 commits February 5, 2025 15:16

chore(condo): DOMA-9987 add new templates and add receiving template …

8eb279b

…from query

fix(condo): DOMA-9987 fix symbols of transfer

344be7f

chore(condo): DOMA-9987 add link on submodule

00cdde8

chore(condo): DOMA-9987 add link on submodule

c6cf4de

Alexander-Turkin temporarily deployed to internal February 5, 2025 10:46 — with GitHub Actions Inactive

toplenboren reviewed Feb 6, 2025

View reviewed changes

Update apps/condo/domains/news/components/NewsForm/BaseNewsForm.tsx

30bb4f7

review changes Co-authored-by: Mikhail Gorbunov <[email protected]>

Alexander-Turkin temporarily deployed to internal February 6, 2025 11:33 — with GitHub Actions Inactive

Alexander-Turkin added 2 commits February 6, 2025 17:17

Revert "chore(condo): DOMA-9987 add link on submodule"

502e4a7

This reverts commit c6cf4de.

Revert "chore(condo): DOMA-9987 add link on submodule"

24a933c

This reverts commit 00cdde8.

Alexander-Turkin temporarily deployed to internal February 6, 2025 12:17 — with GitHub Actions Inactive

toplenboren reviewed Feb 7, 2025

View reviewed changes

feat(condo): DOMA-9987 add hook for normalize text and add test for t…

de49de4

…his case

Alexander-Turkin temporarily deployed to internal February 10, 2025 08:18 — with GitHub Actions Inactive

fix(condo): DOMA-9987 delete replace

84e432a

Alexander-Turkin temporarily deployed to internal February 10, 2025 08:21 — with GitHub Actions Inactive

toplenboren reviewed Feb 10, 2025

View reviewed changes

Update apps/condo/domains/news/schema/NewsItemTemplate.test.js

442c18d

Co-authored-by: Mikhail Gorbunov <[email protected]>

Alexander-Turkin temporarily deployed to internal February 10, 2025 09:51 — with GitHub Actions Inactive

fix(condo): DOMA-9987 review changes

f1c0014

Alexander-Turkin temporarily deployed to internal February 10, 2025 09:57 — with GitHub Actions Inactive

toplenboren approved these changes Feb 10, 2025

View reviewed changes

Alllex202 reviewed Feb 10, 2025

View reviewed changes

Alllex202 approved these changes Feb 10, 2025

View reviewed changes

fix(condo): DOMA-9987 fix test

19f7de5

Alexander-Turkin deployed to internal February 10, 2025 18:16 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doma-9987 synchronization template #5767

doma-9987 synchronization template #5767

Alexander-Turkin commented Feb 5, 2025

toplenboren Feb 6, 2025

Alexander-Turkin Feb 6, 2025

toplenboren Feb 7, 2025

toplenboren Feb 6, 2025

toplenboren Feb 7, 2025

toplenboren Feb 7, 2025

toplenboren Feb 10, 2025

toplenboren Feb 10, 2025

Alllex202 Feb 10, 2025

Alexander-Turkin Feb 10, 2025

Alllex202 Feb 10, 2025 •

edited

Loading

sonarqubecloud bot commented Feb 10, 2025

		@@ -1,4 +1,4 @@
		import { B2BApp } from '@app/condo/schema'
		import { B2BApp, NewsItemTemplateTypeType } from '@app/condo/schema'

doma-9987 synchronization template #5767

Are you sure you want to change the base?

doma-9987 synchronization template #5767

Conversation

Alexander-Turkin commented Feb 5, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alllex202 Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 10, 2025

Quality Gate passed

Alllex202 Feb 10, 2025 •

edited

Loading