Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucla miniscope v4 content #148

Merged
merged 4 commits into from
Dec 9, 2024
Merged

ucla miniscope v4 content #148

merged 4 commits into from
Dec 9, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Nov 4, 2024

ucla miniscope v4 content

Resolve #65

@cjsha cjsha added this to the Two milestone Nov 4, 2024
@ChucklesOnGitHub
Copy link
Contributor

Took a look at this, looks good! But I don't have time to make the changes.
In the workflow:

  • PortVoltage should be empty, not 5.2
  • Memory Monitor Data should be set to BreakoutBoard/MemoryMonitor

In the docs

  • the camera data section is empty, I think sth went wrong

cjsha added 2 commits December 6, 2024 02:20
- In creating this page, I found some formatting fixes I wanted to implement in other files as well:
  - do not double format link (i.e. hyperlinks don't need to be wrapped in ``
  - do not repeat hyperlinks within the same page
  - not important to say "the `DeviceName` property is set to". just say "`DeviceName` is set to"
  - use xref instead of hyperlink to bonsai classes
  - unify templates to use workflowLocation instead of workflowDirectory
  - hard-wrap some files
- Change some readsizes to read every ~1ms
@cjsha cjsha marked this pull request as ready for review December 6, 2024 17:27
@cjsha
Copy link
Member Author

cjsha commented Dec 6, 2024

sorry the latest commit kinda went all over the place. check the commit message to see what im talking about

@cjsha cjsha changed the title Initial ucla miniscope v4 content ucla miniscope v4 content Dec 6, 2024
@cjsha
Copy link
Member Author

cjsha commented Dec 9, 2024

The FourCC is worth discussing further, but we can do GREY in the meanwhile to be uniform with miniscope-docs

Copy link
Contributor

@ChucklesOnGitHub ChucklesOnGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Also, remove bold format around "Output"
@cjsha cjsha merged commit f705f6e into main Dec 9, 2024
3 checks passed
@cjsha cjsha deleted the issue-65 branch December 9, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add miniscope user guide
2 participants